Correct amule.profile for upnp #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty-snake
reviewed
Jun 24, 2021
|
I agree with you that one commented line could be interesting to other users. |
|
@chrpinedo Are you interested in adding a comment to the profile? Otherwise I would suggest to merge as-is, in order to get the bug fixed. |
In order UPnP to work netlink protocol must be enabled.
|
Since netlink protocol should be avoided when it is not required, I modified the commit to add one comment to the profile. If you agree, you could merge it. |
rusty-snake
approved these changes
Oct 2, 2021
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order UPnP to work netlink protocol must be added